fix EVP_PKEY #55
Merged
fix EVP_PKEY #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Nov 4, 2024
lib/resty/rsa.lua
Outdated
| if not pcall(function () return C.EVP_PKEY_size(pkey) end) then | ||
| size = C.EVP_PKEY_get_size(pkey) | ||
| else | ||
| size=C.EVP_PKEY_size(pkey) |
There was a problem hiding this comment.
Suggested change
| size=C.EVP_PKEY_size(pkey) | |
| size = C.EVP_PKEY_size(pkey) |
lib/resty/rsa.lua
Outdated
| local size = C.EVP_PKEY_size(pkey) | ||
| --local size = C.EVP_PKEY_size(pkey) | ||
| local size | ||
| if not pcall(function () return C.EVP_PKEY_size(pkey) end) then |
There was a problem hiding this comment.
Let's use pcall like
lua-resty-rsa/lib/resty/rsa.lua
Line 151 in d4e22cf
lib/resty/rsa.lua
Outdated
| @@ -388,7 +389,13 @@ function _M.new(_, opts) | |||
| end | |||
| end | |||
|
|
|||
| local size = C.EVP_PKEY_size(pkey) | |||
| --local size = C.EVP_PKEY_size(pkey) | |||
spacewander
approved these changes
Nov 4, 2024
lib/resty/rsa.lua
Outdated
| @@ -388,7 +396,8 @@ function _M.new(_, opts) | |||
| end | |||
| end | |||
|
|
|||
| local size = C.EVP_PKEY_size(pkey) | |||
| local size=evp_pkey_size(pkey) | |||
There was a problem hiding this comment.
Suggested change
| local size=evp_pkey_size(pkey) | |
| local size = evp_pkey_size(pkey) |
|
thank you, actually this is my first pull request |
I hope you're having fun! |
spacewander
approved these changes
Nov 4, 2024
|
@nogolang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix EVP_PKEY and old version still work