Skip to content

Comments

Enabling ci build for py-torch 2.9 on rocm#1582

Open
renjithravindrankannath wants to merge 106 commits intospack:developfrom
renjithravindrankannath:py-torch-2.8-rocm
Open

Enabling ci build for py-torch 2.9 on rocm#1582
renjithravindrankannath wants to merge 106 commits intospack:developfrom
renjithravindrankannath:py-torch-2.8-rocm

Conversation

@renjithravindrankannath
Copy link
Contributor

No description provided.

@renjithravindrankannath
Copy link
Contributor Author

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Sep 19, 2025

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Sep 19, 2025

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/aotriton/package.py
repos/spack_repo/builtin/packages/libtree/package.py
repos/spack_repo/builtin/packages/py_torch/package.py
repos/spack_repo/builtin/packages/yaml_cpp/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/py_torch/package.py:77: [E501] line too long (100 > 99 characters)
repos/spack_repo/builtin/packages/py_torch/package.py:94: [E501] line too long (100 > 99 characters)
repos/spack_repo/builtin/packages/py_torch/package.py:95: [E501] line too long (101 > 99 characters)
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enable building and testing the PyTorch 2.8 ROCm stack by activating previously excluded PyTorch ecosystem packages, adding ROCm-specific dependencies and patches, and tightening compiler/feature constraints.

  • Activate PyTorch-related Python packages in the ROCm stack environment.
  • Introduce ROCm-conditional variant logic and new conflicts plus a ROCm dependency (hipsparselt) and patch for PyTorch 2.8.
  • Add a compiler conflict for newer aotriton binaries.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
stacks/ml-linux-x86_64-rocm/spack.yaml Enables previously commented PyTorch ecosystem packages in the ROCm stack.
repos/spack_repo/builtin/packages/py_torch/package.py Adds ROCm-specific variant defaults, conflicts, hipsparselt dependency, and a ROCm patch for 2.8.
repos/spack_repo/builtin/packages/aotriton/package.py Adds compiler conflict for binary-distributed versions.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the ci Issues related to Continuous Integration label Sep 23, 2025
@renjithravindrankannath
Copy link
Contributor Author

@spackbot rerun pipeline

@spackbot-app
Copy link

spackbot-app bot commented Jan 27, 2026

I've started that pipeline for you!

@spackbot-triage spackbot-triage bot requested a review from bgoglin February 3, 2026 23:54
@renjithravindrankannath
Copy link
Contributor Author

@spackbot rerun pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 11, 2026

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
pr head: 99fc821, gitlab commit parents: ['63bb690', '34c0eb4']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues related to Continuous Integration conflicts dependencies python update-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants