Skip to content

Comments

Enabling ci build for py-torch 2.9, 2.10 on rocm#3287

Open
renjithravindrankannath wants to merge 14 commits intospack:developfrom
renjithravindrankannath:py-torch-2.10-rocm
Open

Enabling ci build for py-torch 2.9, 2.10 on rocm#3287
renjithravindrankannath wants to merge 14 commits intospack:developfrom
renjithravindrankannath:py-torch-2.10-rocm

Conversation

@renjithravindrankannath
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables building the PyTorch ecosystem in the ROCm CI stack by turning on additional PyTorch-adjacent Python packages and updating the Spack py-torch recipe to better align with ROCm 7 requirements for PyTorch 2.9+.

Changes:

  • Enable multiple PyTorch ecosystem packages (including py-torch, py-torchdata, py-torchmetrics, etc.) in the ml-linux-x86_64-rocm stack.
  • Update py-torch Spack package ROCm constraints/deps for PyTorch 2.9+ (e.g., ROCm 7 component minimums, hip/hipblaslt constraints, additional deps).
  • Bump hwloc’s ROCm SMI dependency minimum to rocm-smi-lib@7.0:.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stacks/ml-linux-x86_64-rocm/spack.yaml Enables PyTorch ecosystem Python packages in the ROCm CI stack.
repos/spack_repo/builtin/packages/py_torch/package.py Updates ROCm dependency constraints and build/patch logic for newer PyTorch on ROCm.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.7.patch Patch metadata updates and ROCm include handling adjustment for PyTorch 2.7 sources.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch Patch metadata updates and ROCm include handling adjustment for PyTorch 2.5 sources.
repos/spack_repo/builtin/packages/hwloc/package.py Requires ROCm SMI library 7.0+ when +rocm.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alalazo this will make your #3175 a bit simpler

- py-torchdata
- py-torchgeo
- py-torchmetrics
# - py-torchvision
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there problems building torchaudio/torchvision with rocm support? torchgeo depends on torchvision, so if the CI is passing, I don't expect these to be an issue.

@adamjstewart adamjstewart self-assigned this Feb 8, 2026
@renjithravindrankannath renjithravindrankannath marked this pull request as ready for review February 9, 2026 09:21
@renjithravindrankannath
Copy link
Contributor Author

@spackbot rerun pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 9, 2026

I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now.

One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a develop pipeline, and will be run when that finishes.

Please check the gitlab commit status message to see if more information is available.

Details
Unexpected response from gitlab: {'message': '404 Commit Not Found'}

@renjithravindrankannath
Copy link
Contributor Author

@spackbot rerun pipeline

@spackbot-app
Copy link

spackbot-app bot commented Feb 11, 2026

I've started that pipeline for you!

@spackbot-triage spackbot-triage bot requested a review from afzpatel February 11, 2026 06:54
@spackbot-triage spackbot-triage bot added the ci Issues related to Continuous Integration label Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Issues related to Continuous Integration conflicts dependencies python update-package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants