Enabling ci build for py-torch 2.9, 2.10 on rocm#3287
Enabling ci build for py-torch 2.9, 2.10 on rocm#3287renjithravindrankannath wants to merge 14 commits intospack:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Enables building the PyTorch ecosystem in the ROCm CI stack by turning on additional PyTorch-adjacent Python packages and updating the Spack py-torch recipe to better align with ROCm 7 requirements for PyTorch 2.9+.
Changes:
- Enable multiple PyTorch ecosystem packages (including
py-torch,py-torchdata,py-torchmetrics, etc.) in theml-linux-x86_64-rocmstack. - Update
py-torchSpack package ROCm constraints/deps for PyTorch 2.9+ (e.g., ROCm 7 component minimums, hip/hipblaslt constraints, additional deps). - Bump
hwloc’s ROCm SMI dependency minimum torocm-smi-lib@7.0:.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| stacks/ml-linux-x86_64-rocm/spack.yaml | Enables PyTorch ecosystem Python packages in the ROCm CI stack. |
| repos/spack_repo/builtin/packages/py_torch/package.py | Updates ROCm dependency constraints and build/patch logic for newer PyTorch on ROCm. |
| repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.7.patch | Patch metadata updates and ROCm include handling adjustment for PyTorch 2.7 sources. |
| repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch | Patch metadata updates and ROCm include handling adjustment for PyTorch 2.5 sources. |
| repos/spack_repo/builtin/packages/hwloc/package.py | Requires ROCm SMI library 7.0+ when +rocm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
repos/spack_repo/builtin/packages/py_torch/PR152569-Update-spack-includes-2.5.patch
Show resolved
Hide resolved
| - py-torchdata | ||
| - py-torchgeo | ||
| - py-torchmetrics | ||
| # - py-torchvision |
There was a problem hiding this comment.
Are there problems building torchaudio/torchvision with rocm support? torchgeo depends on torchvision, so if the CI is passing, I don't expect these to be an issue.
|
@spackbot rerun pipeline |
|
I'm sorry, gitlab does not have your latest revision yet, I can't run that pipeline for you right now. One likely possibility is that your PR pipeline has been temporarily deferred, in which case, it is awaiting a Please check the gitlab commit status message to see if more information is available. DetailsUnexpected response from gitlab: {'message': '404 Commit Not Found'} |
|
@spackbot rerun pipeline |
|
I've started that pipeline for you! |
…is built with rocm
No description provided.