Conversation
haampie
requested review from
alalazo,
becker33,
johnwparent and
tldahlgren
as code owners
spackbot-triage
bot
requested review from
LydDeb,
WeiqunZhang,
ajkotobi,
amd-toolchain-support,
asalmgren,
atmyers,
ax3l,
cessenat,
cyrush,
migueldiascosta,
paolotricerri,
vicentebolea and
williamfgc
haampie
force-pushed
the
hs/typing/which
branch
from
86a7e56 to
9bf888d
Compare
* `which("x")` returns `Optional[Executable]`
* `which("x", required=True)` returns `Executable`
Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>
haampie
force-pushed
the
hs/typing/which
branch
from
9bf888d to
0cd1d46
Compare
Signed-off-by: Harmen Stoppels <harmenstoppels@gmail.com>
alalazo
approved these changes
Feb 16, 2026
alalazo
approved these changes
Feb 17, 2026
tldahlgren
approved these changes
Feb 17, 2026
Member
|
Force merging this one. It seems much more effective to fix point failures for this trivial change, that re-run entire pipelines (current failures are not build related). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which("x")returnsOptional[Executable]which("x", required=True)returnsExecutableBefore:
After: