fix: libseccomp+python build#3495
Merged
kwryankrattiger merged 2 commits intospack:developfrom Feb 21, 2026
Merged
Conversation
libseccomp's python extension Makefile does a check for out of source builds, but fails when srcdir and builddir are different strings but point to the same underlying directory (ie `dir` and `.`). ``` [ /var/tmp/melone1/spack-stage/spack-stage-libseccomp-2.6.0-w24sgwofjl4355bnza4sfvikvesxqawt/spack-src/src/python = . ] || cp /var/tmp/melone1/spack-stage/spack-stage-libseccomp-2.6.0-w24sgwofjl4355bnza4sfvikvesxqawt/spack-src/src/python/seccomp.pyx . cp: '/var/tmp/melone1/spack-stage/spack-stage-libseccomp-2.6.0-w24sgwofjl4355bnza4sfvikvesxqawt/spack-src/src/python/seccomp.pyx' and './seccomp.pyx' are the same file ``` This adds a patch that checks if the file to be copied already exists in the builddir before attempting to copy it over.
becker33
previously approved these changes
Feb 20, 2026
kwryankrattiger
requested changes
Feb 21, 2026
Contributor
kwryankrattiger
left a comment
kwryankrattiger
left a comment
There was a problem hiding this comment.
Link to upstream PR
kwryankrattiger
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libseccomp's python extension Makefile does a check for out of source builds, but fails when srcdir and builddir are different strings but point to the same underlying directory (ie
/dirand.).This adds a patch that checks if the file to be copied already exists in the builddir before attempting to copy it over.