Skip to content

Comments

paraview: add viskores in newer versions#828

Draft
kmorel wants to merge 1 commit intospack:developfrom
kmorel:paraview-viskores
Draft

paraview: add viskores in newer versions#828
kmorel wants to merge 1 commit intospack:developfrom
kmorel:paraview-viskores

Conversation

@kmorel
Copy link
Contributor

@kmorel kmorel commented Jul 28, 2025

Starting with ParaView 6.0, the VTK-m accelerator library changed to Viskores. Update the options to use the new accelerator library.

@kmorel kmorel force-pushed the paraview-viskores branch from 1772dba to 6765f44 Compare July 31, 2025 20:32
@kmorel kmorel marked this pull request as ready for review July 31, 2025 20:32
@kmorel kmorel requested a review from kwryankrattiger July 31, 2025 20:32
@kmorel
Copy link
Contributor Author

kmorel commented Aug 18, 2025

@kwryankrattiger Can you please review this?

@kmorel kmorel force-pushed the paraview-viskores branch from 6765f44 to dc4e687 Compare August 18, 2025 17:55
Copy link
Contributor

@kwryankrattiger kwryankrattiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long on this, I have been back and forth on how best to handle this going forward.

It may be better to just prune this variant at enable the accelerator implicitly. And then external Viskores would be really nice to not have to rebuild it from scratch if we don't have to, especially for the GPU stuff.

@kmorel
Copy link
Contributor Author

kmorel commented Aug 18, 2025

@kwryankrattiger I've updated this package to use an external viskores package. It also removes the use_viskores variant and instead implicitly adds the dependency when needed. I think that generally addresses your comments.

I have not extensively tested this, but the spec at least works.

@kmorel kmorel changed the title paraview: add use_viskores varient paraview: add viskores in newer versions Aug 18, 2025
@kmorel kmorel force-pushed the paraview-viskores branch 2 times, most recently from 048e346 to d0612b8 Compare August 18, 2025 20:20
@kmorel kmorel marked this pull request as draft August 19, 2025 12:10
@kmorel kmorel force-pushed the paraview-viskores branch 2 times, most recently from fcf314e to 8a606eb Compare August 19, 2025 12:34
@kmorel kmorel marked this pull request as ready for review August 19, 2025 12:36
@kmorel kmorel marked this pull request as draft August 25, 2025 11:35
@kmorel kmorel force-pushed the paraview-viskores branch 3 times, most recently from adcbac9 to 7f62338 Compare August 25, 2025 19:59
@kwryankrattiger
Copy link
Contributor

Ported these changes to #192 with other ParaView 6 Updates

Starting with ParaView 6.0, the VTK-m accelerator library changed
to Viskores. Update the options to use the new accelerator library.

The approach has changed slightly. Earlier there was a use_vtkm
option to specify whether VTK-m should be compiled, and it always
compiled the version provided with ParaView. However, the API
for Viskores is stable, so use the external viskores package.

Co-authored-by: Ryan Krattiger <80296582+kwryankrattiger@users.noreply.github.com>
@kmorel kmorel force-pushed the paraview-viskores branch from 7f62338 to e21f146 Compare February 1, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants