spec.py: optimize constructor #51810
Merged
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haampie
force-pushed
the
hs/fix/speedup-spec-constructor
branch
from
be1e157 to
abf1bf3
Compare
Signed-off-by: Harmen Stoppels <me@harmenstoppels.nl>
haampie
force-pushed
the
hs/fix/speedup-spec-constructor
branch
from
abf1bf3 to
824fc7e
Compare
alalazo
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
Spec()triggers the parser to run on a single byte":", which thentriggers slow construction of a version range object.
Given that the parser itself runs
Spec()a lot when parsing dependencies, there'sa curious unintended recursion worth fixing.
Using timeit the constructor goes from 3.25us -> 1.90us. Package load time
improves from 27.3s -> 24.1s, or about 11% reduction.