Refactoring/css perf #106
Merged
Refactoring/css perf #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
spalt08
commented
Jun 6, 2020
spalt08
commented
- improved message rendering
- style fixes
…actoring/css_perf
Finesse
reviewed
Jun 6, 2020
| @@ -3,10 +3,10 @@ | |||
| flex-direction: column; | |||
| overflow-y: hidden; | |||
|
|
|||
| &__avatar { | |||
| & .avatar { | |||
There was a problem hiding this comment.
Зачем это усложнение селектора? Если для увеличения веса селектора, то ИМХО лучше использовать !important.
There was a problem hiding this comment.
почему усложнение?
это для font-size инициалов
There was a problem hiding this comment.
Усложнение, потому что это вложенный селектор вида .foo .bar. Вариант до был проще для браузера. Нужно хотя бы .foo > .bar.
There was a problem hiding this comment.
давай пока вмерджим а аватары я после лотти поправлю везде в отдельные классы?
There was a problem hiding this comment.
Смотри сам, я сообщил тебе
Finesse
approved these changes
Jun 7, 2020
misupov
reviewed
Jun 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.