Add smrnmi extension basic support#366
Open
knute-mips wants to merge 10 commits intosparcians:mainfrom
Open
Conversation
knute-mips
requested review from
colby-nyce,
kathlenemagnus,
klingaard and
lzhu-pub
as code owners
knute-mips
commented
Mar 25, 2026
Contributor
Author
There was a problem hiding this comment.
@colby-nyce -- to get regression to pass on MacOS, I had to rearrange the code below. I was getting an assert on line 608 (invalid event UID). I think we have to run the SimLoopTeardown after we query the events?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSRs in place,
mnretstubbed out, not implemented.closes #364