-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: recent agendas filtering #488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sanghou
reviewed
May 22, 2024
yumincho
force-pushed
the
feat/recently-terminated-agendas
branch
from
May 23, 2024 11:17
863441f
to
a8b6d66
Compare
rebase를 안 한 채로 푸시해서 CI 에러가 있었습니다. 수정해서 force push 했어요! |
yumincho
force-pushed
the
feat/recently-terminated-agendas
branch
from
May 23, 2024 11:37
a8b6d66
to
d049b50
Compare
main으로 다시 rebase 했습니다 ;_; |
rjsdn0
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #475
종료된 투표 중 24시간 내 시작된 투표들만 필터링해주는 토글 스위치를 추가했습니다.
(브랜치명이 recently-started-agendas여야 할 것 같네요 😅 )
스크린샷
recent_agendas.mov
추가 Task
이후 Task *