Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recent agendas filtering #488

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

yumincho
Copy link
Member

@yumincho yumincho commented May 5, 2024

요약 *

It closes #475

종료된 투표 중 24시간 내 시작된 투표들만 필터링해주는 토글 스위치를 추가했습니다.
(브랜치명이 recently-started-agendas여야 할 것 같네요 😅 )

스크린샷

recent_agendas.mov

추가 Task

  • toggle hovering 시 cursor: pointer 설정

이후 Task *

  • 없음

Copy link

netlify bot commented May 5, 2024

Deploy Preview for biseo-preview ready!

Name Link
🔨 Latest commit d049b50
🔍 Latest deploy log https://app.netlify.com/sites/biseo-preview/deploys/664f2a90b2983400089c70ad
😎 Deploy Preview https://deploy-preview-488--biseo-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yumincho yumincho self-assigned this May 5, 2024
@yumincho yumincho added the enhancement New feature or request label May 5, 2024
@yumincho yumincho requested review from Sanghou, lunikai and rjsdn0 May 5, 2024 02:30
@yumincho yumincho marked this pull request as ready for review May 5, 2024 02:30
@yumincho yumincho force-pushed the feat/recently-terminated-agendas branch from 863441f to a8b6d66 Compare May 23, 2024 11:17
@yumincho
Copy link
Member Author

rebase를 안 한 채로 푸시해서 CI 에러가 있었습니다. 수정해서 force push 했어요!

@yumincho yumincho force-pushed the feat/recently-terminated-agendas branch from a8b6d66 to d049b50 Compare May 23, 2024 11:37
@yumincho
Copy link
Member Author

main으로 다시 rebase 했습니다 ;_;

Copy link
Collaborator

@rjsdn0 rjsdn0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/web/src/components/organisms/AgendaSection.tsx Outdated Show resolved Hide resolved
@rjsdn0 rjsdn0 merged commit baf988d into main May 24, 2024
5 checks passed
@rjsdn0 rjsdn0 deleted the feat/recently-terminated-agendas branch May 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

투표 정렬시 디바이더로 분리
3 participants