-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade All #388
Upgrade All #388
Conversation
a0baf78
to
cc36342
Compare
160f94e
to
6f062ec
Compare
58ba908
to
e688806
Compare
e688806
to
e707cd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 수고하셨습니다
@@ -17,7 +17,7 @@ run: | |||
python manage.py runserver 0.0.0.0:9000 | |||
|
|||
shell: | |||
python manage.py shell -i bpython | |||
python manage.py shell -i ipython |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bpython에서 ipython으로 바꾼 이유가 있나요? ipython을 써 본적은 없는데 bpython의 autocompletion과 깔끔한 UI와 같은 기능이 개인적으로 괜찮았던거 같아서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ipython은 Jupyter Notebook과 같은 UI를 제공합니다. Autocompletion도 잘 돼서 사용에 불편함은 없을 것 같은데 편하신 것을 사용하면 될 것 같습니다.
(참고) Stack Overflow: What are the differences between ipython and bpython?
verify_ssl = true | ||
name = "pypi" | ||
|
||
[packages] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
django-ses가 안보이는데 추가해야 할 것 같습니다. 또한 이번에 빠진 패키지들이 정말로 사용이 되지 않는지 꼼꼼히 확인해야 할 것 같습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모든 파일에서 django_ses
를 검색했을 때 검색 결과가 없었고 AWS도 확인했을 때 SES를 더 이상 사용하지 않는 것 같아서 c839f17 에서 제거했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
게시물 신고 시 이메일이 와야 한다는 게 생각나서 복구했습니다. 9f5ed57
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 0021번 migration과 squash 할 수 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else sso_info["last_name"] + sso_info["first_name"] | ||
) | ||
if not self.sso_user_info: | ||
return self.nickname # Portal crawled users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
카이스트 계정이 없는 일반 사용자들 (입주업체 등) 도 이 경우에 해당되나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 부분은 SPARCS SSO 회원가입 정보가 있는지 확인하는 부분이어서 일반 사용자들은 여기에 해당하지 않습니다.
It is a PR continued from #386.