Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor model fields #401

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Refactor model fields #401

merged 1 commit into from
Oct 5, 2023

Conversation

injoonH
Copy link
Member

@injoonH injoonH commented Jul 31, 2023 •
edited
Loading

Update IntegerField to PositiveIntegerField if it is more appropriate.

@injoonH injoonH self-assigned this Jul 31, 2023
@injoonH injoonH marked this pull request as ready for review August 23, 2023 12:06
@injoonH injoonH marked this pull request as draft September 21, 2023 12:20
@injoonH injoonH linked an issue Sep 21, 2023 that may be closed by this pull request
Update deleted_at nullable #416
Closed
@injoonH injoonH removed a link to an issue Oct 5, 2023
Update deleted_at nullable #416
Closed
@injoonH injoonH marked this pull request as ready for review October 5, 2023 14:53
@injoonH injoonH marked this pull request as draft October 5, 2023 14:57
@injoonH injoonH marked this pull request as ready for review October 5, 2023 15:12
retroinspect
retroinspect approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@retroinspect retroinspect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@injoonH injoonH merged commit f5b7e92 into develop Oct 5, 2023
1 check passed
@injoonH injoonH deleted the refactor/model-fields branch October 5, 2023 15:32
@injoonH injoonH mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retroinspect retroinspect retroinspect approved these changes

Assignees

@injoonH injoonH

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@injoonH @retroinspect