-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mypy): add stubs to remove mypy linting errors #415
Merged
DoyunShin
merged 9 commits into
refactor/type-hint
from
refactor/type-hint-django-stubs
Sep 22, 2023
Merged
feat(mypy): add stubs to remove mypy linting errors #415
DoyunShin
merged 9 commits into
refactor/type-hint
from
refactor/type-hint-django-stubs
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add stubs to fix mypy typehint errors
mypy.ini follow_imports not exists in mypy settings
using vscode:extension/matangover.mypy to lint the codes.
DoyunShin
added
dependencies
Pull requests that update a dependency file
refactor
labels
Sep 21, 2023
injoonH
approved these changes
Sep 21, 2023
django_extension에 대한 대응이 안이루어져 draft로 전환합니다. |
DoyunShin
changed the title
feat(mypy): add stubs to enable mypy
feat(mypy): add stubs to remove mypy linting errors
Sep 21, 2023
DoyunShin
requested review from
injoonH
and removed request for
ddungiii and
injoonH
September 21, 2023 13:16
…tubs feat(mypy): Add typing-extensions
Added types about bleach, python-tateutil, tqdm. Ignored boto3, django_filters, celery, firebase_admin, environ, django_elasticsearch_dsl, elasticsearch_dsl
Qndndn
approved these changes
Sep 22, 2023
ddungiii
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type-hint 작업하는 두분의 확인이 완료되어 머지 진행합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
To enable vscode mypy settings.
Added stubs to make django and djangorestframework not to make typehint errors.
Fixed elements