Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mypy): add stubs to remove mypy linting errors #415

Merged
merged 9 commits into from
Sep 22, 2023

Conversation

DoyunShin
Copy link
Member

Reason

To enable vscode mypy settings.
Added stubs to make django and djangorestframework not to make typehint errors.

Fixed elements

  • mypy.ini - linting settings
  • vscode/settings.json set mypy to default linter.
  • Pipfile - add django-stubs djangorestframework-stubs to fix mypy linting errors.

Add stubs to fix mypy typehint errors
mypy.ini follow_imports not exists in mypy settings
using vscode:extension/matangover.mypy to lint the codes.
@DoyunShin DoyunShin added dependencies Pull requests that update a dependency file refactor labels Sep 21, 2023
@DoyunShin DoyunShin self-assigned this Sep 21, 2023
mypy.ini Outdated Show resolved Hide resolved
@DoyunShin DoyunShin marked this pull request as draft September 21, 2023 12:31
@DoyunShin
Copy link
Member Author

django_extension에 대한 대응이 안이루어져 draft로 전환합니다.

@DoyunShin DoyunShin changed the title feat(mypy): add stubs to enable mypy feat(mypy): add stubs to remove mypy linting errors Sep 21, 2023
@DoyunShin DoyunShin requested review from injoonH and removed request for ddungiii and injoonH September 21, 2023 13:16
Qndndn and others added 4 commits September 21, 2023 15:29
Added types about bleach, python-tateutil, tqdm.
Ignored boto3, django_filters, celery, firebase_admin, environ,
django_elasticsearch_dsl, elasticsearch_dsl
@DoyunShin DoyunShin marked this pull request as ready for review September 21, 2023 16:42
Copy link
Member

@ddungiii ddungiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 하나만 확인해주세용

LGTM

Pipfile Show resolved Hide resolved
@DoyunShin
Copy link
Member Author

type-hint 작업하는 두분의 확인이 완료되어 머지 진행합니다.

@DoyunShin DoyunShin merged commit 91f6589 into refactor/type-hint Sep 22, 2023
1 check passed
@injoonH injoonH deleted the refactor/type-hint-django-stubs branch October 26, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants