feat(email): Change smtp provider #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Sendmail check all done. |
injoonH
reviewed
Nov 3, 2023
injoonH
reviewed
Nov 4, 2023
| message: str, | ||
| sender_mail: str, | ||
| mailing_list: list[str], | ||
| each: bool = False, |
There was a problem hiding this comment.
each=True를 default로 하는 게 더 나아 보이는데 False로 하신 이유가 있나요?
There was a problem hiding this comment.
이전에 학생지원팀? 분들에게 보내는게 False로 되어있어서 그렇게 했습니다.
지금 생각해보니 기본적으로 True로 해둔 다음에 학교에게 전합니다 게시판만 False로 걸어두는게 좋을 듯 하네요. 수정 진행하겠습니다.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.