-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxiDialog 리팩토링 #71
The head ref may contain hidden characters: "#70-taxidialog-\uB9AC\uD329\uD1A0\uB9C1"
taxiDialog 리팩토링 #71
Conversation
추가적으로 해결한 문제점: 확인 버튼 하단 패딩이 맞지 않습니다. |
Dialog 리팩토링☑️ 표시는 현재 커밋에 반영된 부분입니다. I. 테마 코드 분리
II. 공통 설정 상수화constants와 theme.dart를 활용하여 공통되는 설정과 관련된 내용을 정리하고 있습니다. III. (추가 진행중) |
@ybmin 제가 확인이 늦었네요ㅜㅜ 예리한 지적 감사합니다. 테마 관련 코드들을 통합하시고 계신 것 같은데 다음을 참고해 주시면 좋을 것 같습니다.
|
lib/views/taxiDialog.dart
Outdated
style: GoogleFonts.roboto( | ||
textStyle: const TextStyle( | ||
color: Color(0xFFC8C8C8), | ||
fontSize: 13, | ||
fontWeight: FontWeight.normal))), | ||
style: Theme.of(context).textTheme.labelMedium), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 깔끔해지네요 ㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
깔끔해졌네요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Summary
It closes #70