Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InAppNotification #78

Merged
merged 13 commits into from
Sep 19, 2023
Merged

InAppNotification #78

merged 13 commits into from
Sep 19, 2023

Conversation

ybmin
Copy link
Contributor

@ybmin ybmin commented Sep 10, 2023

Summary

It closes #77

@ybmin ybmin added the enhancement New feature or request label Sep 10, 2023
@ybmin ybmin self-assigned this Sep 10, 2023
@ybmin
Copy link
Contributor Author

ybmin commented Sep 11, 2023 •
edited
Loading

Work Done

image

subTitle과 imageUrl이 없을때

image

To Do:

  • 버튼 onPressed 만들기

  • 스와이프시 material banner 삭제

  • 배너 animation 추가

  • eventHandler popup_inAppNotification

- [ ] pushHistory 구현

  • 최대 margin 적용 (

@ybmin ybmin marked this pull request as ready for review September 18, 2023 17:08
@ybmin ybmin requested review from happycastle114, sboh1214 and 14KGun and removed request for happycastle114 September 18, 2023 17:09
14KGun
14KGun approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@14KGun 14KGun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

happycastle114
happycastle114 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@happycastle114 happycastle114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@happycastle114 happycastle114 merged commit be759a3 into main Sep 19, 2023
2 checks passed
@happycastle114 happycastle114 deleted the #77-inAppNotification branch September 19, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@14KGun 14KGun 14KGun approved these changes

@happycastle114 happycastle114 happycastle114 approved these changes

@sboh1214 sboh1214 Awaiting requested review from sboh1214

Assignees

@ybmin ybmin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

인앱알림
3 participants
@ybmin @happycastle114 @14KGun