#813 2024 추석 이벤트 : 2023 추석 코드 복사 #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhyeonkwon
requested review from
kmc7468,
happycastle114,
ybmin,
predict-woo and
14KGun
3 tasks
✅ Deploy Preview for taxi-dev-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ybmin
approved these changes
Aug 25, 2024
|
확인 감사합니다! |
|
현재
백엔드 수정 사항 제안 (2024 봄학기와 달리, 새터반 관련 검증 삭제) -> 백엔드 개발자 분들의 검토가 필요합니다 |
|
답변이 늦어 죄송합니다! 초대 링크 형식은 |
kmc7468
reviewed
Aug 29, 2024
kmc7468
reviewed
Aug 29, 2024
kmc7468
reviewed
Aug 29, 2024
kmc7468
reviewed
Aug 29, 2024
kmc7468
reviewed
Aug 29, 2024
kmc7468
reviewed
Sep 1, 2024
| content="링크로 이동하여 택시에 동승하세요!" | ||
| /> | ||
| <!-- TODO: FIXME --> | ||
| <meta property="og:image" content="%FRONT_URL%/graph.png" /> |
kmc7468
reviewed
Sep 1, 2024
| "/home/eventJoin" | ||
| ); | ||
| const getDynamicLink = (to, fallback = true) => { | ||
| const { host, androidPacakgeName, iosAppBundleId, appStoreId } = |
There was a problem hiding this comment.
androidPacakgeName 의 오타는 의도된 것으로 보입니다. 프러덕션 .env 파일을 보면 실제로 이름이 저렇게 되어있습니다.
kmc7468
reviewed
Sep 1, 2024
| </LinkEvent2023FallInstagramStoryShare> | ||
| </WhiteContainer> | ||
| ) : completedQuests && !completedQuests.includes("adPushAgreement") ? ( | ||
| ) : completedQuests && !isAdPushAgreementCompleted ? ( |
There was a problem hiding this comment.
나중에 초대 링크 생성 버튼을 여기에 추가하면 될 것 같습니다.
kmc7468
reviewed
Sep 1, 2024
Comment on lines
+54
to
+68
| await axios({ | ||
| url: `/events/2024fall/items/purchase/${itemInfo._id}`, | ||
| method: "post", | ||
| onSuccess: ({ reward }) => { | ||
| fetchEvent2024FallInfo(); | ||
| fetchItems?.(); | ||
| modalProps.onChangeIsOpen?.(false); | ||
| if (itemInfo.itemType === 3 && reward) { | ||
| setRewardItem?.(reward); | ||
| } else { | ||
| setShareItem?.(itemInfo); | ||
| } | ||
| }, | ||
| onError: () => setAlert("구매를 실패하였습니다."), | ||
| }); |
There was a problem hiding this comment.
request body에 json으로 amount 를 넘겨줘야 합니다. 차후 개설된 상점 구현 PR에서 수정하면 됩니다.
kmc7468
reviewed
Sep 1, 2024
| const notificationValue = { | ||
| type: "default" as const, | ||
| imageUrl: quest.imageUrl, | ||
| title: "퀘스트 완료", |
There was a problem hiding this comment.
프론트엔드에서는 "퀘스트 달성"이란 워딩을 사용하고 있어, 차후 PR에서 통일성을 위해 이 부분 문구도 수정하는게 좋을 것 같습니다.
kmc7468
reviewed
Sep 1, 2024
|
|
||
| const PublicNoticeContainer = () => { | ||
| const { transactions }: { transactions: Array<Transaction> } = useQuery.get( | ||
| "/events/2024fall/publicNotice/recentTransactions" |
There was a problem hiding this comment.
삭제된 API입니다. 마찬가지로 상점 작업할 때 함께 수정 필요합니다.
kmc7468
approved these changes
Sep 1, 2024
kmc7468
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #813
2023fall 이벤트 관련 코드를 복사하여, 2024fall 관련 route에서 볼 수 있도록 하였습니다.
주의사항
ToDo : 2023fall로 시작하는 주석이 해당 부분을 나타냅니다.Images or Screenshots
Further Work