#837 채팅창에서 메세지별로 안 읽은 사람 수 보여주기 #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
❌ Deploy Preview for taxi-dev-preview failed.
|
Hyogyeong8
changed the title
kmc7468
requested changes
Feb 13, 2025
| )} | ||
| <div css={styleMessageDetail}> | ||
| {unreadUsersNum(chat.time) > 0 && ( | ||
| <UnreadUsers value={unreadUsersNum(chat.time)} /> |
There was a problem hiding this comment.
UnreadUsers 컴포넌트를 별도로 분리하신 이유가 있나요?? 그냥 div를 바로 사용해도 좋을 것 같습니다
There was a problem hiding this comment.
넵 div 바로 사용하면 될 것 같습니다!
| @@ -74,6 +81,24 @@ const MessageSet = ({ chats, layoutType, roomInfo }: MessageSetProps) => { | |||
| const isBot = authorId === "bot"; | |||
| const isAlone = roomInfo.part.length === 1; | |||
|
|
|||
| // Chat의 time에 따라 안 읽은 사람 수 설정 | |||
| const unreadUsersNum = useCallback( | |||
There was a problem hiding this comment.
useCallback을 사용하는 것보다는, useMemo를 이용해서 안 읽은 사람 수 자체를 메모이제이션 하는게 성능상 더 유리할 것 같습니다!
There was a problem hiding this comment.
GPT 랑 얘기를 좀 해봤는데, 어짜피 readAtList랑 time이 많이 바뀌니깐 메모이제이션 해봤자 별 효용이 없다고 하네요. 그리고 웬만한 최적화는 react가 알아서 해준다고 합니다. 그래서 걍 메모이제이션 뺐습니다.
kmc7468
approved these changes
Feb 15, 2025
Hyogyeong8
deleted the
#837-show-number-of-unread-people-per-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #837
Images or Screenshots