Subfolder location is now injected (when needed) into default.conf file.

[Bladedu]

PR Type

Enhancement

---

Description

• Improved subfolder configuration handling in docker-entrypoint.sh:
  • Replaced separate envsubst command with sed injection of subfolder configuration
  • Updated main envsubst command to include subfolder variables
  • Added logging for subfolder configuration activation
• Simplified templates/subfolder.conf by removing redundant content
• Added placeholder for subfolder configuration in templates/default.conf
• Removed old HTTP redirect configuration

---

Changes walkthrough 📝

	Relevant files
Enhancement	docker-entrypoint.sh Streamline subfolder configuration injection                          docker-entrypoint.sh Removed separate envsubst command for subfolder configuration Added sed command to inject subfolder configuration into default.conf Updated envsubst command to include subfolder variables Added print statement for activating subfolder configuration +5/-5      subfolder.conf Simplify subfolder configuration                                                  templates/subfolder.conf Removed most of the file content, leaving only the subfolder-specific location block +0/-53
Configuration changes	default.conf Add subfolder configuration placeholder                                    templates/default.conf Added a placeholder comment for subfolder configuration +2/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[paolomainardi]

/describe

[paolomainardi]

/review

[paolomainardi]

/improve

[sparkfabrik-ai-bot]

PR Description updated to latest commit (9a5fbc4)

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Category	Suggestion	Score
Error handling	Add error handling for the configuration modification command Consider adding error handling for the 'sed' command to ensure the subfolder configuration is applied successfully. docker-entrypoint.sh [249] -sed -e '/#subfolder/r /templates/subfolder.conf' -i /templates/default.conf; +if ! sed -e '/#subfolder/r /templates/subfolder.conf' -i /templates/default.conf; then + echo "Error: Failed to apply subfolder configuration" >&2 + exit 1 +fi Suggestion importance[1-10]: 9 Why: Adding error handling is crucial for robustness and can prevent silent failures, significantly improving the script's reliability.	9
Best practice	Replace 'print' with 'echo' for better shell compatibility Use 'echo' instead of 'print' for consistency with shell scripting conventions and better portability across different shells. docker-entrypoint.sh [248] -print "Activating subfolder configuration" +echo "Activating subfolder configuration" Suggestion importance[1-10]: 8 Why: This suggestion enhances portability and follows shell scripting conventions, which is important for maintainability.	8
	Use a more descriptive comparison value for improved readability Consider using a more descriptive variable name instead of '0' for the NGINX_SUBFOLDER comparison. For example, use an empty string or 'false' to improve code readability. docker-entrypoint.sh [247] -if [ "${NGINX_SUBFOLDER}" != 0 ]; then +if [ -n "${NGINX_SUBFOLDER}" ]; then Suggestion importance[1-10]: 7 Why: The suggestion improves code readability by using a more meaningful comparison, but it's not a critical change.	7
Maintainability	Add a descriptive comment for the configuration placeholder Consider adding a comment explaining the purpose of the '#subfolder' placeholder to improve maintainability for future developers. templates/default.conf [61] -#subfolder +# Placeholder for subfolder configuration (injected by docker-entrypoint.sh) Suggestion importance[1-10]: 6 Why: While this improves maintainability, it's a minor enhancement that doesn't affect functionality.	6

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Possible Configuration Error: The change in docker-entrypoint.sh to include NGINX_SUBFOLDER and NGINX_SUBFOLDER_ESCAPED variables in the envsubst command without conditional checks might introduce issues if NGINX_SUBFOLDER is not set. Ensure that this change does not affect configurations where subfolders are not used. Redundant Code Removal: The removal of the specific envsubst command for subfolder configurations in docker-entrypoint.sh and the subsequent removal of most of the subfolder.conf content might simplify the configuration process but ensure that all necessary configurations are still applied correctly. It's important to verify that the new method of injecting the subfolder configuration directly into default.conf does not miss any critical settings.