-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Remove Python 3.8 conditions in test.yml #96
Conversation
b46fcb4
to
cf5df10
Compare
will test this |
I had to drop the python 3.13 support first as this was causing issues (no xarray-dataclasses compatible in python 3.13) that were previously not caught due to the if condition. |
For later we might decide to downscale the CI a bit? |
We no longer support Python 3.8
d859918
to
163c50b
Compare
OK, the tests are running again. Windows, Linux, Intel mac are passing. For ARM mac, we get some errors:
@melonora I will not have to dive into this until late next week if you want to take a look we could skip ARM mac for now. |
I will try to enforce a compute for now as it seems one is the lazy representation and the other one in memory. I have seen similar things with macs before that there are different behaviours for dask across mac versions. |
I will check whether tests pass with spatialdata if they do, I will revert last commit and skip MAC arm and open an issue, but then still release. Alright with you @thewtex? |
tests in spatialdata pass |
so I suspect still an issue with the test data |
Baseline test comparisons are failing, tracked in #100.
0f0a80d
to
189f985
Compare
We no longer support Python 3.8