Fix "margin" option for PDF creation (#104)

* fix "margin" option The browser.js option is actually called "margin" not "margins". * Fix tests with renamed "margin" option
spatie · Oct 25, 2017 · b62f951 · b62f951
1 parent 9029014
commit b62f951
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Browsershot.php b/src/Browsershot.php
@@ -308,7 +308,7 @@ public function createPdfCommand($targetPath): array
         }
 
         if ($this->margins) {
-            $command['options']['margins'] = [
+            $command['options']['margin'] = [
                 'top' => $this->margins['top'].'mm',
                 'right' => $this->margins['right'].'mm',
                 'bottom' => $this->margins['bottom'].'mm',

diff --git a/tests/BrowsershotTest.php b/tests/BrowsershotTest.php
@@ -181,7 +181,7 @@ public function it_can_create_a_command_to_generate_a_pdf()
                 'path' => 'screenshot.pdf',
                 'printBackground' => true,
                 'landscape' => true,
-                'margins' => ['top' => '10mm', 'right' => '20mm', 'bottom' => '30mm', 'left' => '40mm'],
+                'margin' => ['top' => '10mm', 'right' => '20mm', 'bottom' => '30mm', 'left' => '40mm'],
                 'pageRanges' => '1-3',
                 'width' => '210mm',
                 'height' => '148mm',
@@ -211,7 +211,7 @@ public function it_can_create_a_command_to_generate_a_pdf_with_paper_format()
                 'path' => 'screenshot.pdf',
                 'printBackground' => true,
                 'landscape' => true,
-                'margins' => ['top' => '10mm', 'right' => '20mm', 'bottom' => '30mm', 'left' => '40mm'],
+                'margin' => ['top' => '10mm', 'right' => '20mm', 'bottom' => '30mm', 'left' => '40mm'],
                 'pageRanges' => '1-3',
                 'format' => 'a4',
                 'viewport' => [