Add append mode #219
Merged
Add append mode #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of appending (using >> ) instead of overwriting ( > ) when dumping a MySQL DB to a file.
This is useful when doing a two-step dump, where in the first step you dump the whole schema, and in the second step you dump the contents of only some tables. For example:
For an extended example of that functionality, see https://github.com/netz98/n98-magerun/wiki/Stripped-Database-Dumps ; I've implemented it myself in https://github.com/LBannenberg/laravel-mysqldump
I was able to do it myself ( https://github.com/LBannenberg/laravel-mysqldump ) by extending \Spatie\DbDumper\Databases\MySql , but with this PR that would not be needed anymore, especially now that #208 made the doNotDumpData() command available.
Because I'm not sure if this functionality also makes sense for other DBs than MySQL I only added the method to set the flag in \Spatie\DbDumper\Databases\MySql, but the flag is used in the main \Spatie\DbDumper\DbDumper class. This seemed preferable to copying the echoToFile command to \Spatie\DbDumper\Databases\MySql .
I added an exception when trying to combine append-mode with compressors because I don't expect that behavior to be compatible.