Merge branch 'RobertBoes-patch-1'

spatie · Feb 1, 2024 · 93f4515 · 93f4515
2 parents d34740b + d82a2aa
commit 93f4515
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 7 deletions.
diff --git a/resources/js/components/AppDebugWarning.tsx b/resources/js/components/AppDebugWarning.tsx
@@ -30,6 +30,7 @@ export default function AppDebugWarning() {
                     <a
                         className="mt-1.5 underline inline-flex items-center gap-2"
                         target="_blank"
+                        rel="noopener noreferrer"
                         href="https://flareapp.io/docs/ignition-for-laravel/security"
                     >
                         <FontAwesomeIcon icon={faShieldAlt} className="text-sm opacity-50" />

diff --git a/resources/js/components/Footer.tsx b/resources/js/components/Footer.tsx
@@ -11,17 +11,30 @@ export default function Footer() {
                 </li>
                 <li>·</li>
                 <li>
-                    <a href="https://github.com/spatie/laravel-ignition" target="_blank"
-                       className="hover:text-red-500">Source</a>
+                    <a
+                        href="https://github.com/spatie/laravel-ignition"
+                        target="_blank"
+                        rel="noopener noreferrer"
+                        className="hover:text-red-500"
+                    >Source</a>
                 </li>
                 <li>·</li>
                 <li>
-                    <a href="https://flareapp.io/docs/ignition/introducing-ignition/overview" target="_blank"
-                       className="hover:text-red-500">Docs</a>
+                    <a
+                        href="https://flareapp.io/docs/ignition/introducing-ignition/overview"
+                        target="_blank"
+                        rel="noopener noreferrer"
+                        className="hover:text-red-500"
+                    >Docs</a>
                 </li>
                 <li>·</li>
                 <li>
-                    <a href="https://laravel.com" target="_blank" className="hover:text-red-500">Laravel</a>
+                    <a
+                        href="https://laravel.com"
+                        target="_blank"
+                        rel="noopener noreferrer"
+                        className="hover:text-red-500"
+                    >Laravel</a>
                 </li>
             </ul>
             <div className="text-sm flex items-center">
@@ -30,6 +43,7 @@ export default function Footer() {
                 <a
                     href="https://flareapp.io/?utm_campaign=ignition&utm_source=ignition"
                     target="_blank"
+                    rel="noopener noreferrer"
                     className="font-medium hover:text-purple-500"
                 >
                     <FlareIcon className={"inline-block -mt-1 ml-1 mr-px"}/>

diff --git a/resources/js/components/NavBarItem.tsx b/resources/js/components/NavBarItem.tsx
@@ -36,7 +36,12 @@ export default function NavBarItem({
 
     return (
         <li ref={navRef}>
-            <a href={href || `#${name}`} target={href ? '_blank' : '_self'} onClick={onClickHandler}>
+            <a
+                href={href || `#${name}`}
+                target={href ? '_blank' : '_self'}
+                onClick={onClickHandler}
+                rel={href ? 'noopener noreferrer' : ''}
+            >
                 <button
                     className={`
                     group px-3 sm:px-5 h-10 uppercase tracking-wider text-xs font-medium

diff --git a/resources/js/components/SettingsDropdown.tsx b/resources/js/components/SettingsDropdown.tsx
@@ -110,6 +110,7 @@ export default function SettingsDropdown({ isOpen }: Props) {
                         className="text-xs ~text-gray-500 hover:text-red-500 flex items-center underline transition-colors"
                         href="https://flareapp.io/ignition?utm_campaign=ignition&utm_source=ignition"
                         target="_blank"
+                        rel="noopener noreferrer"
                     >
                         Docs
                         <IgnitionIcon />

diff --git a/resources/js/components/ShareDropdown.tsx b/resources/js/components/ShareDropdown.tsx
@@ -52,7 +52,7 @@ export default function ShareDropdown({ isOpen }: Props) {
         try {
             const response = await shareClient(igniteData, selectedSectionNames);
 
-            window.open(response.owner_url);
+            window.open(response.owner_url, '_blank', 'noopener,noreferrer');
 
             setPublicUrl(response.public_url);
         } catch (e) {
@@ -78,6 +78,7 @@ export default function ShareDropdown({ isOpen }: Props) {
                         className="text-xs ~text-gray-500 hover:text-violet-500 flex items-center underline transition-colors"
                         href="https://flareapp.io/docs/ignition/introducing-ignition/sharing-errors?utm_campaign=ignition&utm_source=ignition"
                         target="_blank"
+                        rel="noopener noreferrer"
                     >
                         Docs
                         <FlareIcon />

diff --git a/resources/js/components/ui/CopyableUrl.tsx b/resources/js/components/ui/CopyableUrl.tsx
@@ -17,6 +17,7 @@ export default function CopyableUrl({url, openText, helpText}: Props) {
                 <a
                     href={url}
                     target="_blank"
+                    rel="noopener noreferrer"
                     className="underline ~text-violet-500 hover:~text-violet-600"
                 >
                     <FontAwesomeIcon icon={faExternalLinkAlt} className="opacity-50 text-xs mr-1"/>