fix DataTypeScriptTransformer cursor paginator properties#1098
Open
UltraWelfare wants to merge 1 commit intospatie:mainfrom
Open
fix DataTypeScriptTransformer cursor paginator properties#1098UltraWelfare wants to merge 1 commit intospatie:mainfrom
UltraWelfare wants to merge 1 commit intospatie:mainfrom
Conversation
|
Dear contributor, because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened an issue on
typescript-transformerbut I found out that the code generating the type belongs to this repo..spatie/typescript-transformer#116
Looking at the
blameof CursorPaginator.php there was never aprev_cursor_urlnor anext_cursor_url.The patch just renames them to
prev_page_urlandnext_page_urlrespectively.