Open
Conversation
`serialize()` throws an error if virtual properties are returned by `__sleep()`. This commit excludes them from the returned array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves the following issues related to data classes with virtual properties:
DataPropertyFactorynow checks the attribute and if the property is virtual usingisVirtual()(when it's available).__sleep()inBaseData. However, virtual properties can't be serialized. These properties are now excluded from the array returned by__sleep().It's important to note that this only applies to virtual properties. Backed properties with hooks don't need to be computed and can be serialized. Tests were added to ensure backed properties with hooks aren't treated as virtual properties.