add failing test for serializing created_at
event property
#471
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I encountered this bug when I was trying to store a collection of Eloquent models as events (Long story...)
If you define a stored event property with the name
created_at
, it will be set to null when the event is serialiazed.I've been digging through the code, trying to figure out why this happens and found the following:
The ObjectNormalizer uses the PropertyAccessor from Symfony, and setting the following line (In the Symfony package) to false will fix the behavior:
https://github.com/symfony/property-access/blob/7.1/PropertyAccessor.php#L472
The ObjectNormalizer is triggering the PropertyAccessor on this line:
https://github.com/spatie/laravel-event-sourcing/blob/main/src/Support/ObjectNormalizer.php#L55
Do you know if there is a way to configure this from outside? I'm open to contributing a fix myself, but I'm a little out of my comfort zone, and I don't want to reinvent any wheels unnecessarily 😄