Merge pull request #45 from pauljosephkrogulec/feat/switch-DateTime-t…

…o-DateTimeInterface feat: switch DateTime to DateTimeInterface
spatie · Apr 5, 2023 · 5d95139 · 5d95139
2 parents 356b707 + 02f60b7
commit 5d95139
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/BaseUrlSigner.php b/src/BaseUrlSigner.php
@@ -3,6 +3,7 @@
 namespace Spatie\UrlSigner;
 
 use DateTime;
+use DateTimeInterface;
 use Spatie\UrlSigner\Exceptions\InvalidExpiration;
 use Spatie\UrlSigner\Exceptions\InvalidSignatureKey;
 use Spatie\UrlSigner\Support\Url;
@@ -27,7 +28,7 @@ abstract protected function createSignature(
 
     public function sign(
         string $url,
-        int|DateTime $expiration,
+        int|\DateTimeInterface $expiration,
         string $signatureKey = null,
     ): string {
         $signatureKey ??= $this->defaultSignatureKey;
@@ -95,13 +96,13 @@ protected function getIntendedUrl(string $url): string
         ]);
     }
 
-    protected function getExpirationTimestamp(DateTime|int $expirationInSeconds): string
+    protected function getExpirationTimestamp(\DateTimeInterface|int $expirationInSeconds): string
     {
         if (is_int($expirationInSeconds)) {
             $expirationInSeconds = (new DateTime())->modify($expirationInSeconds.' seconds');
         }
 
-        if (! $expirationInSeconds instanceof DateTime) {
+        if (! $expirationInSeconds instanceof DateTimeInterface) {
             throw InvalidExpiration::wrongType();
         }
 

diff --git a/src/UrlSigner.php b/src/UrlSigner.php
@@ -2,13 +2,13 @@
 
 namespace Spatie\UrlSigner;
 
-use DateTime;
+use DateTimeInterface;
 
 interface UrlSigner
 {
     public function sign(
         string $url,
-        int|DateTime $expiration,
+        int|\DateTimeInterface $expiration,
         string $signatureKey = null
     ): string;