Add signing and validation tests for special and reserved query param…

…eters.
spatie · Dec 6, 2023 · 730d254 · 730d254
1 parent fb8d006
commit 730d254
Show file tree

Hide file tree

Showing 2 changed files with 48 additions and 0 deletions.
diff --git a/tests/Md5UrlSignerTest.php b/tests/Md5UrlSignerTest.php
@@ -83,3 +83,27 @@
     expect($this->urlSigner->validate($signedUsingCustomKey, 'custom-key'))->toBeTrue();
     expect($this->urlSigner->validate($signedUsingCustomKey, 'wrong-custom-key'))->toBeFalse();
 });
+
+it('can sign url which has special characters in the query parameters', function ($url) {
+    $expiration = 100;
+
+    $signedUrl = $this->urlSigner->sign($url, $expiration);
+
+    expect($this->urlSigner->validate($signedUrl))->toBeTrue();
+})->with([
+    ['https://myapp.com/?foo=bar baz'],
+    ['https://myapp.com/?foo=bar%20baz'],
+    ['https://myapp.com/?foo=bar@baz.com'],
+]);
+
+it('can sign url which has reserved query parameters', function ($url) {
+    $expiration = 100;
+
+    $signedUrl = $this->urlSigner->sign($url, $expiration);
+
+    expect($this->urlSigner->validate($signedUrl))->toBeTrue();
+})->with([
+    ['https://myapp.com/?foo=bar&expires=100&signature=abc123'],
+    ['https://myapp.com/?foo=bar&expires=100'],
+    ['https://myapp.com/?foo=bar&signature=abc123'],
+]);
diff --git a/tests/Sha256UrlSignerTest.php b/tests/Sha256UrlSignerTest.php
@@ -92,3 +92,27 @@
     expect($this->urlSigner->validate($signedUsingCustomKey, 'custom-key'))->toBeTrue();
     expect($this->urlSigner->validate($signedUsingCustomKey, 'wrong-custom-key'))->toBeFalse();
 });
+
+it('can sign url which has special characters in the query parameters', function ($url) {
+    $expiration = 100;
+
+    $signedUrl = $this->urlSigner->sign($url, $expiration);
+
+    expect($this->urlSigner->validate($signedUrl))->toBeTrue();
+})->with([
+    ['https://myapp.com/?foo=bar baz'],
+    ['https://myapp.com/?foo=bar%20baz'],
+    ['https://myapp.com/?foo=bar@baz.com'],
+]);
+
+it('can sign url which has reserved query parameters', function ($url) {
+    $expiration = 100;
+
+    $signedUrl = $this->urlSigner->sign($url, $expiration);
+
+    expect($this->urlSigner->validate($signedUrl))->toBeTrue();
+})->with([
+    ['https://myapp.com/?foo=bar&expires=100&signature=abc123'],
+    ['https://myapp.com/?foo=bar&expires=100'],
+    ['https://myapp.com/?foo=bar&signature=abc123'],
+]);