Merge pull request #40 from peter279k/test_enhancement

Improve some testing stuffs

.github/workflows/run-tests.yml

@@ -31,5 +31,10 @@ jobs:
             - name: Install dependencies
               run: composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
 
-            - name: Execute tests
+            - name: Execute tests on Ubuntu OS
+              if: matrix.operating-system == 'ubuntu-latest'
+              run: XDEBUG_MODE=coverage vendor/bin/phpunit
+
+            - name: Execute tests on Windows OS
+              if: matrix.operating-system == 'windows-latest'
               run: vendor/bin/phpunit

.gitignore

@@ -2,3 +2,4 @@ build
 composer.lock
 docs
 vendor
+.phpunit.result.cache

tests/QueryParameterBagTest.php

@@ -46,7 +46,7 @@ public function it_can_set_a_parameter()
 
         $queryParameterBag->set('offset', 10);
 
-        $this->assertEquals(10, $queryParameterBag->get('offset'));
+        $this->assertSame('10', $queryParameterBag->get('offset'));
     }
 
     /** @test */
@@ -73,8 +73,8 @@ public function it_can_be_created_from_a_string()
     {
         $queryParameterBag = QueryParameterBag::fromString('offset=10&limit=20');
 
-        $this->assertEquals(10, $queryParameterBag->get('offset'));
-        $this->assertEquals(20, $queryParameterBag->get('limit'));
+        $this->assertSame('10', $queryParameterBag->get('offset'));
+        $this->assertSame('20', $queryParameterBag->get('limit'));
     }
 
     /** @test */

tests/UrlBuildTest.php

@@ -13,7 +13,7 @@ public function it_can_build_a_url_with_a_host()
     {
         $url = Url::create()->withHost('spatie.be');
 
-        $this->assertEquals('//spatie.be', $url);
+        $this->assertSame('//spatie.be', (string) $url);
     }
 
     /** @test */

tests/UrlImmutableTest.php

@@ -47,7 +47,7 @@ public function with_port_returns_a_new_instance()
 
         $clone = $url->withPort(9000);
 
-        $this->assertEquals(0, $url->getPort());
+        $this->assertNull($url->getPort());
         $this->assertEquals(9000, $clone->getPort());
     }
 

tests/UrlQueryParametersTest.php

@@ -12,7 +12,7 @@ public function it_can_get_a_query_parameter()
     {
         $url = Url::create()->withQuery('offset=10');
 
-        $this->assertEquals(10, $url->getQueryParameter('offset'));
+        $this->assertSame('10', $url->getQueryParameter('offset'));
     }
 
     /** @test */
@@ -44,7 +44,7 @@ public function it_can_set_a_query_parameter()
     {
         $url = Url::create()->withQueryParameter('offset', 10);
 
-        $this->assertEquals(10, $url->getQueryParameter('offset'));
+        $this->assertSame('10', $url->getQueryParameter('offset'));
     }
 
     /** @test */