The userId property is normalized to int so no need to type-cast it
#258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaze
force-pushed
the
spaze/user-id-int
branch
from
405c686 to
a09eb16
Compare
Resolves ``` ------ ------------------------------------------------------- Line app/User/Manager.php ------ ------------------------------------------------------- 129 Unreachable statement - code above always terminates. ------ ------------------------------------------------------- ``` which happens because nette/database 3.2.0 added `never` return type to Row::__get(). This way, PhpStorm complains "Return value must be of type 'int', 'never' returned" but PHPStan doesn't, so...
spaze
force-pushed
the
spaze/user-id-int
branch
from
a09eb16 to
4ccf191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
which happens because nette/database 3.2.0 added
neverreturn type to Row::__get().This way, PhpStorm complains "Return value must be of type 'int', 'never' returned" but PHPStan doesn't, so...