Don't cache blog post previews #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding only allowedTags so far because that's what I use.
It's been cached when the BlogPost object was created before it was sent to sendPreview() (where caching was disabled a little bit too late), and also in onValidate where we still want the data to be validated (so can't call setValidationScope([])). The original BlogPost object is still cached in actionEdit, but that's the original one. not the previewed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been cached when the
BlogPostobject was created before it was sent tosendPreview()(where caching was disabled a little bit too late), and also inonValidatewhere we still want the data to be validated (so can't callsetValidationScope([])). The originalBlogPostobject is still cached inactionEdit(), but that's the original one. not the previewed one.