-
Notifications
You must be signed in to change notification settings - Fork 0
Feedback #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-classroom
wants to merge
106
commits into
feedback
Choose a base branch
from
main
base: feedback
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feedback #1
Changes from all commits
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
a75053d
Setting up GitHub Classroom Feedback
github-classroom[bot] a7a155c
Add gitignore file
53c5dce
Add GNU GPL license
833495f
Merge pull request #2 from spbu-coding-2022/repo_setup
vacmannnn f6808fc
feat(gitignor): ignored gradle files
vacmannnn f0f938b
feat(gitignor): ignored MacOS files
raf-nr e3b0c57
add: gradle init files
vacmannnn 768167c
Merge from gradle_init
vacmannnn 055cec8
feat(gitignore): ignored IDEA directory
vacmannnn a0c768c
add: init files for trees
vacmannnn bbd2864
fix: pulled gitignore changes
vacmannnn cb35bbc
add: mergeable config
raf-nr 9c07562
Merge pull request #8 from spbu-coding-2022/add/mergeable_config
raf-nr 1f3df0b
feat: find function and init of root node in bst
vacmannnn 130b3ea
add: KVPairs class for a key-value pair
raf-nr 8eefcfe
add: init files for trees
raf-nr 4887010
Merge branch 'tree_init' into trees_init
vacmannnn 765069e
add: new init files with implementation
vacmannnn c2d86e6
feat: implement remove in BST, changed add func
vacmannnn 28c1fab
add: created files for remaining trees
vacmannnn d16815f
feat: delete 'node' file
raf-nr dc2329a
feat: splitting a remote 'Node' file into separate files
raf-nr a55d8e4
add: AVL and RB nodes
raf-nr 1e89f70
feat: placing node classes in a separate directory
raf-nr 0f703c5
feat: transferring the KVPairs class to a file with the AbstractNode …
raf-nr 1cbe12c
fix: removed unnecessary generics, added new ones
raf-nr 4932a8f
fix: changed import directives, return of find function
vacmannnn cca9c2d
fix: node types in tree declaration, cleared 'app' file
raf-nr 743e183
Merge init tress files to develop
vacmannnn 3bdba1a
add: CI file that tests project build while PR
vacmannnn 7e852fa
Add CI with building project in pull requests
vacmannnn 5cb24ee
add: README.md
vacmannnn b2ee631
fix: name of parameters, generics in nodes
raf-nr bf28099
fix: typo with comparison operator
raf-nr 00b8837
fix: class declaration, node types
raf-nr b9811ef
fix: change structure, names and add print method
3cf5748
Merge branch 'develop' into fix/bst_tree
vacmannnn d48f624
fix: binary tree structure and generics
c9a84be
add: init files for trees test
vacmannnn 7db522b
Implement BSTree, git workflow, readme, license (#14)
vacmannnn d6712f1
fix: remove unnecessary recursive add function
682ee75
add: raw add and remove methods
5ce9c4f
fix: find search by key
vacmannnn 29c9cd3
Merge pull request #15 from spbu-coding-2022/bstree_fix
f72e3a2
implement AVL-tree
raf-nr d99f143
feat: function to validate BSTree
vacmannnn e14b6a8
add: basic red black tree implementation
75bc5c8
Correction of functions for adding and deleting nodes
raf-nr 6bb4671
fix: null node fix
20ac92a
fix: add nodes by key and value
5852fc8
add: red black tree implementation
e9db236
add: tests for binary search tree
vacmannnn 554fda9
feat: find, add, remove tests for AVL
vacmannnn 677d6e4
fix: null pointer error
e9e2ef6
fix: correct typo
8de59d3
fix: null pointer bug
6161956
add: functions to work with flat file database
vacmannnn fc60c3d
feat: find, add, remove tests for RB
vacmannnn 5a293d2
feat(readme): written current changes
vacmannnn 680ac64
Merge branch 'main' into develop
vacmannnn 5020e74
Implement RB, AVL trees, tests and flat tipe database
vacmannnn dd75fb3
fix: simplify code and improve safety
bd1eba4
add: test with removing a non-existent node
raf-nr 1fcea32
fix: remove in BST and AVL throw exception if node not exist
vacmannnn b8d6280
add: functions for saving the AVL-tree in the database
raf-nr b54c9cd
fix: improve code safety and readability
946744c
Merge remote-tracking branch 'refs/remotes/origin/develop' into develop
e83df4b
fix: make proper formatting
7289816
fix: beautify code structure
990b27b
feat: readme decoration, remove in flatFileDB
vacmannnn 6a34e65
Merge branch 'main' into develop
vacmannnn a82736f
Implement sql, git decoration, remove in flatFileDB
vacmannnn 03b2979
add: balance tests for BS and AVL trees
raf-nr 8f5de1c
feat: CI runs on 3 platforms with jacoco test coverage
vacmannnn 8ea161d
Merge branch 'main' into develop
vacmannnn cf3d84b
CI runs on 3 platforms with jacoco test coverage
vacmannnn a44d643
feat: using csv library to work with write and read functions
vacmannnn 9025887
add: raw compose app
b236744
feat: home screen implementation
vacmannnn 3ac89e6
feat: HomeScreen buttons are the same size
vacmannnn f7d9ce2
add: node view model for displaying them
raf-nr 469d95e
feat(flatFilesDB): write and insert functions works only with key and…
vacmannnn a49c989
feat: nodes in BSTScreen can be printed, implemented functions to wor…
vacmannnn bd364e0
add: folder refactoring - different files to screens
vacmannnn 892320d
feat: implemented navigation between homeScreen and BSTScreen
vacmannnn e38d03a
feat(BSTScreen): back to menu buttom
vacmannnn f5ce146
add: basic gui implementation
da005f2
fix: use find function, privacy change, return of balance
vacmannnn 5f01f20
delete: RBBalanceTest
vacmannnn e6cd06f
add: balance tests
d231b6e
add: Neo4j database implementation
vacmannnn 9fc654e
add: menu of functions for actions on trees, implementation of the re…
raf-nr 65bc677
add: text fields
46c33e8
feat(BSTScreen): implemented add, remove, find functions
vacmannnn 2371a67
fix: removed unnecessary bst screen parameter
vacmannnn 3fedc21
fix: beautify code
c2452f4
Implement basic GUI, add neo4j support and more tests
9905453
fix(sql): deleting unnoticed outputs, fixed bugs with statement closing
raf-nr 59974d1
feat(BSTScreen): text message about errors
vacmannnn 68efb51
add: BSTree draw implementation
raf-nr 2c627db
fix: beautify nodes
raf-nr dbf6862
fix: empty file error in bstscreen
14603b0
fix: tree draw in the center
raf-nr 4a5c68c
add: avl tree drawing
raf-nr c34268e
feat: added test coverage
vacmannnn e96d46f
feat: add photo in README.md with small changes
vacmannnn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # | ||
| # https://help.github.com/articles/dealing-with-line-endings/ | ||
| # | ||
| # Linux start script should use lf | ||
| /gradlew text eol=lf | ||
|
|
||
| # These are Windows script files and should use crlf | ||
| *.bat text eol=crlf | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| version: 2 | ||
| mergeable: | ||
| - when: pull_request.*, pull_request_review.* | ||
| name: 'Check decoration' | ||
| validate: | ||
| - do: title | ||
| must_exclude: | ||
| regex: ^\[WIP\] | ||
| - do: description | ||
| no_empty: | ||
| enabled: true | ||
| message: Description matter and should not be empty. Provide detail with **what** was changed, **why** it was changed, and **how** it was changed. | ||
| - do: approvals | ||
| min: | ||
| count: 1 | ||
| limit: | ||
| users: | ||
| - vacmannnn | ||
| - gladiuswq | ||
| - raf-nr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Run Kotlin project build with code and test coverage | ||
|
|
||
| on: [push] | ||
|
|
||
| jobs: | ||
| run: | ||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: zulu | ||
| java-version: '17' | ||
| cache: gradle | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Для Gradle лучше использовать специальный официальный экшн -- у него лучше кэширование (и как бонус, можно чуть более компактно через него же Gradle-таски запускать) |
||
|
|
||
| - name: Run gradle build | ||
| run: ./gradlew build | ||
|
|
||
| - if: matrix.os == 'ubuntu-latest' # Container action is only supported on Linux | ||
| name: Run Test Coverage | ||
| run: ./gradlew jacocoTestReport | ||
|
|
||
| - if: matrix.os == 'ubuntu-latest' | ||
| name: Jacoco Code Coverage Report | ||
| uses: cicirello/jacoco-badge-generator@v2.8.0 | ||
| with: | ||
| generate-branches-badge: true | ||
| jacoco-csv-file: app/build/jacoco/report.csv | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # Compiled class file | ||
| *.class | ||
|
|
||
| # Log file | ||
| *.log | ||
|
|
||
| # Package Files # | ||
| *.jar | ||
| *.war | ||
| *.nar | ||
| *.ear | ||
| *.zip | ||
| *.tar.gz | ||
| *.rar | ||
|
|
||
| .gradle | ||
| **/build/ | ||
| !src/**/build/ | ||
|
|
||
| # Ignore Gradle GUI config | ||
| gradle-app.setting | ||
|
|
||
| # Avoid ignoring Gradle wrapper jar file (.jar files are usually ignored) | ||
| !gradle-wrapper.jar | ||
|
|
||
| # Avoid ignore Gradle wrappper properties | ||
| !gradle-wrapper.properties | ||
|
|
||
| # Cache of project | ||
| .gradletasknamecache | ||
|
|
||
| # Eclipse Gradle plugin generated files | ||
| # Eclipse Core | ||
| .project | ||
| # JDT-specific (Eclipse Java Development Tools) | ||
| .classpath | ||
|
|
||
| # MacOS | ||
| *.DS_Store | ||
| .AppleDouble | ||
| # Ignore Gradle build output directory | ||
| build | ||
| # Ignore idea workflow files | ||
| .idea/* |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
На Винде у вас какой-то варнинг вылезает -- можно в Actions увидеть