Fix bug with clearNestedAutomaton function#38
Open
AlexShmak wants to merge 1 commit intospbu-se:developfrom
Open
Fix bug with clearNestedAutomaton function#38AlexShmak wants to merge 1 commit intospbu-se:developfrom
clearNestedAutomaton function#38AlexShmak wants to merge 1 commit intospbu-se:developfrom
Conversation
| } | ||
|
|
||
| private fun clearExecutionStatesInternal(visited: MutableSet<Automaton>) { | ||
| protected fun clearExecutionStatesInternal(visited: MutableSet<Automaton>) { |
Collaborator
There was a problem hiding this comment.
Я думаю, будет менее хрупко и более понятно, если оставить одну публичную функцию fun clearExecutionStates(visited: MutableSet<Automaton>) и убрать clearExecutionStatesInternal() и clearExecutionStatesFromOutside(), а во всех местах, где очищение вызывается снаружи, просто передать visitedStates=emptySet()
Collaborator
There was a problem hiding this comment.
Чтобы понизить вероятность будущих ошибок, связанных с рекурсией, советую оставить именно fun clearExecutionStates(visited: MutableSet<Automaton>), а не fun clearExecutionStates(visited: MutableSet<Automaton> = mutableSetOf())
IlyaMuravjov
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.