Extending schedule and storage types with attributes #2284
+96
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added example storage types for AMD GPU vector registers.
almaeder
force-pushed
the
gpu_storage_types
branch
from
3b53eaf to
9396748
Compare
Collaborator
|
I think this loses the extensibility of the enum. I will check |
Collaborator
|
@almaeder please run pre-commit (See https://github.com/spcl/dace/blob/main/CONTRIBUTING.md#code-style) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a nested-class concept for extending DaCe schedule and storage types with attributes. As an example, AMD GPU-related vector register storage types have been added.