You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Agree with the goal of the PR, but seems like we need some more work to fix this since the tests are failing.
As far as I understand the issue, we are wrapping the error_response in the ServerErrorMiddleware with our connexion_wrapper from the ExceptionMiddleware which returns a coroutine, while the ServerErrorMiddleware expects a normal function here. We could solve this by just implementing the relevant part (translating between Connexion and Starlette) synchronously in the error_response method.
Another difference is that the ServerErrorMiddleware still raises the error after returning the error response. So we'll need to update our tests to accommodate this and catch the error. We also need to check what the effect of this is when running the application with different servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the catch-all error handler for unhandled exceptions from the
ExceptionMiddleware.Since the introduction of @nielsbox'
ServerErrorMiddleware, the duplication of this feature has become kind of confusing / unnecessary.