Skip to content

Revise exception handling doc on error handler functions #2021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revise exception handling doc on error handler functions #2021

wants to merge 1 commit into from

Conversation

chrisinmtown
Copy link
Contributor

@chrisinmtown chrisinmtown commented Dec 17, 2024 •
edited
Loading

Document that a sync error-handler function is run in a threadpool.
Extend the add_error_handler function's Pydoc

Fixes #2019

@coveralls
Copy link

coveralls commented Dec 17, 2024 •
edited
Loading

Coverage Status

coverage: 94.354%. remained the same
when pulling 67f4ab4 on chrisinmtown:2019-async-exc-handler
into a1c53db on spec-first:main.

@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch from 85de9ab to 45406de Compare December 18, 2024 10:25
@chrisinmtown chrisinmtown mentioned this pull request Dec 22, 2024
Open
@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch from 45406de to c74d411 Compare December 23, 2024 21:34
@chrisinmtown chrisinmtown changed the title Revise exceptions doc to use async coroutine handler functions Revise exception handling doc on error handler functions Dec 23, 2024
@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch 2 times, most recently from 4f80dd1 to 89b902b Compare December 27, 2024 16:09
@chrisinmtown
Copy link
Contributor Author

Would someone please decipher this failed check output:

  /home/runner/.cache/pre-commit/repobghb8bkc/py_env-python3.11/lib/python3.11/site-packages/referencing/_core.py:565: error: Invalid "type: ignore" comment
  /home/runner/.cache/pre-commit/repobghb8bkc/py_env-python3.11/lib/python3.11/site-packages/referencing/_core.py:566: error: Invalid "type: ignore" comment
  Found 2 errors in 1 file (errors prevented further checking)

Is mypy complaining about something in this Pydoc change, or is something wrong in the pipeline?

@chrisinmtown
Copy link
Contributor Author

I scaled back the proposed change based on what I learned from #2026 please try to find time to review.

@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch 2 times, most recently from dea88bb to 6248d48 Compare April 20, 2025 15:06
@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch from 6248d48 to b32847d Compare May 4, 2025 20:04
@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch from b32847d to 1cfdf24 Compare May 28, 2025 20:51
@chrisinmtown
Revise exception handling doc on error handler functions
67f4ab4 
Document that a sync error-handler function is run in a threadpool.
Extend the add_error_handler function's Pydoc.

Fixes spec-first#2019
@chrisinmtown chrisinmtown force-pushed the 2019-async-exc-handler branch from 1cfdf24 to 67f4ab4 Compare June 9, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stack trace not available to logger in v3 error handler function
2 participants
@chrisinmtown @coveralls