Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gergo/uvSetup #374

Merged
merged 26 commits into from
Jan 22, 2025
Merged

gergo/uvSetup #374

merged 26 commits into from
Jan 22, 2025

Conversation

gjedlicska
Copy link
Collaborator

  • chore: set up uv as a project and package manager
  • chore: run ruff format
  • chore: run ruff format
  • chore: run ruff format
  • chore: run ruff format
  • chore: fix all ruff issues
  • chore: test fix WIP

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@dogukankaratas
Copy link

It'd be better if we update our README about getting started with uv. For dynamic versioning let's not forget to add uv pip install -e .

dogukankaratas
dogukankaratas reviewed Jan 20, 2025
View reviewed changes
uv.lock Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an error when I try to run a script with uv.

image

When I remove the following part and run it again there is no issue. Do we really need that part?

image

pyproject.toml

[tool.ruff.lint]
select = [
# pycodestyle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great 🚀

src/specklepy/serialization/base_object_serializer.py Show resolved Hide resolved
@gjedlicska
Copy link
Collaborator Author

It'd be better if we update our README about getting started with uv. For dynamic versioning let's not forget to add uv pip install -e .

uv sync will take care of this

@dogukankaratas dogukankaratas merged commit b4e2f37 into v3-dev Jan 22, 2025
6 checks passed
@dogukankaratas dogukankaratas deleted the gergo/uvSetup branch January 22, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogukankaratas dogukankaratas dogukankaratas approved these changes

@JR-Morgan JR-Morgan JR-Morgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjedlicska @dogukankaratas @JR-Morgan