This repository has been archived by the owner on Aug 28, 2021. It is now read-only.
Reverted a line which caused ALL libraries from kits to be explicitly loaded #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loaded instead of just the ones which reference SpeckleCore. This is causing the issue where the SpeckleGSAInterfaces.dll in the SpeckleStructural kit to be loaded twice. Note: this dll will be removed from the SpeckleStructural kit in the near future but this change is needed in the meantime.
|
Seems like it was changed by @didimitrie in December when he converted the library to .net standard, can you maybe test with .net standard to see if it works? I tried and it builds fine... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys
I see during kit initialisation that SpeckleCore used to load all kit assemblies using a ReflectionOnlyLoadFrom call but it was commented out in favour of a LoadFrom call at some point.
Could we revert it back to being a ReflectionOnlyLoadFrom call? That would solve this issue:
SpeckleGSA and the conversion library within the SpeckleStructural kit both reference the same file (SpeckleGSAInterfaces.dll) and I'm finding that it is often loaded twice into the loaded modules list, i.e. from 2 separate locations.
Note: this library doesn't need to be in the SpeckleStructural kit at all - in fact I'll remove it as soon as SpeckleRevit has been updated with the latest SpeckleCore version - but for the next short while SpeckleGSA will need to be able to cope with it.
I have a few workarounds in mind but I thought I might try to cause a change at the root of the issue -
Can you remember why it was changed in the first place?
Cheers