fix(stream): fix deletion bug and list get bug

Fix delete so it now properly deletes all children of a stream when it is deleted. Fix get all so it
also exposes public streams.

app/api/streams/StreamDelete.js

@@ -14,8 +14,7 @@ module.exports = ( req, res ) => {
     .then( stream => PermissionCheck( req.user, 'delete', stream ) )
     .then( stream => {
       myStream = stream
-      DataStream.remove( { streamId: { $in: [ ...myStream.children, req.params.streamId ] } } )
-      return stream.remove( )
+      return DataStream.deleteMany( { streamId: { $in: [ ...myStream.children, req.params.streamId ] } } )
     } )
     .then( ( ) => {
       return res.send( { success: true, message: `Stream ${req.params.streamId} and its children have been deleted.`, deletedStreams: [ ...myStream.children, req.params.streamId ] } )

app/api/streams/StreamGetAll.js

@@ -28,7 +28,8 @@ module.exports = ( req, res ) => {
   finalCriteria.$or = [
     { owner: req.user._id },
     { 'canWrite': mongoose.Types.ObjectId( req.user._id ) },
-    { 'canRead': mongoose.Types.ObjectId( req.user._id ) }
+    { 'canRead': mongoose.Types.ObjectId( req.user._id ) },
+    { 'private': false }
   ]
 
   DataStream.find( finalCriteria, query.options.fields, { sort: query.options.sort, skip: query.options.skip, limit: query.options.limit } )