Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Command with -v displays AppVersion instead of executing the command. #1400

Closed
JKamsker opened this issue Dec 5, 2023 · 3 comments · Fixed by #1427
Closed

[BUG] Command with -v displays AppVersion instead of executing the command. #1400

JKamsker opened this issue Dec 5, 2023 · 3 comments · Fixed by #1427
Assignees
Labels
area-CLI Command-Line Interface bug Something isn't working

Comments

@JKamsker
Copy link

JKamsker commented Dec 5, 2023

Information

  • OS: Windows 11
  • Spectre Version: 0.47.1-preview.0.26
  • Terminal: WT

Describe the bug
A regression occurred in Spectre.Console version 0.47.1-preview.0.26 where the command option "-v" is now being misinterpreted as a request for version information within command settings, rather than being recognized as a command argument, which was the correct behavior in version 0.47.1-preview.0.17.

To Reproduce

  1. Create a command with a "-v" option in its settings.
  2. Execute the command with the "-v" option followed by a value (e.g., app command -v 1.2.3).
  3. The application displays version information instead of executing the command.

Expected behavior
The command should execute as intended when the "-v" option is provided, as it did in version 0.47.1-preview.0.17.

Actual Behavior
Starting from version 0.47.1-preview.0.26, the application displays the version information and the command is not executed.

Additional context
The PR #1399 tests this bug. When fixed, the test should succeed. (Failure happens in Test Run )

@JKamsker JKamsker added bug Something isn't working needs triage labels Dec 5, 2023
@github-project-automation github-project-automation bot moved this to Todo 🕑 in Spectre Console Dec 5, 2023
@patriksvensson
Copy link
Contributor

@JKamsker I will take a look at it. Btw, this is an exemplary bug report, thank you! 🙂

@FrankRay78
Copy link
Contributor

I introduced the bug @JKamsker, unfortunately. I knew it was a breaking change, and flagged it as such, but I think the change in functionality is probably now best described as a regression. I'll add this to my stack to review/address.

@FrankRay78
Copy link
Contributor

FYI. I've submitted the PR above to revert this to existing behaviour @JKamsker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CLI Command-Line Interface bug Something isn't working
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

3 participants