Skip to content

Make -v|--version opt-in #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2024
Merged

Make -v|--version opt-in #1531

merged 3 commits into from
Apr 25, 2024

Conversation

patriksvensson
Copy link
Contributor

Fixes #1530

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

We added an automatic version option in 0.49 with good intentions, but we forgot that people might already use --version as an option for a root command.

This PR makes -v|--version completely opt-in using config.SetApplicationVersion(..) or config.UseAssemblyInformationalVersion().

@patriksvensson
Add Verify.Tool dotnet tool
78948e4
@patriksvensson
Make -v|--version opt-in
8593045 
We added an automatic version option in 0.49. We did this with good
intentions, but forgot that people might already use --version
as an option for a root command.

This commit makes -v|--version completely opt-in.
@patriksvensson
Add extension method to use automatic application version
975c25e
@patriksvensson patriksvensson marked this pull request as ready for review April 25, 2024 17:56
@patriksvensson patriksvensson changed the title Feature/version fix Make -v|--version opt-in Apr 25, 2024
@patriksvensson patriksvensson merged commit 5d4b2c8 into spectreconsole:main Apr 25, 2024
@patriksvensson patriksvensson deleted the feature/version-fix branch April 25, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in parameter --version conflicts with existing one
1 participant
@patriksvensson