Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant explain settings ctor #1534

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Remove redundant explain settings ctor #1534

merged 1 commit into from
Apr 27, 2024

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Apr 26, 2024 •
edited by patriksvensson
Loading

Fixes #1532.

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Removed the explain settings ctor and added property setters.

Please upvote 👍 this pull request if you are interested in it.

patriksvensson
patriksvensson approved these changes Apr 27, 2024
View reviewed changes
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@patriksvensson patriksvensson merged commit b1b50a2 into spectreconsole:main Apr 27, 2024
3 checks passed
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@gitfool gitfool deleted the gh1532 branch April 27, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriksvensson patriksvensson patriksvensson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExplainCommand+Settings ctor fails ServiceProvider.ValidateService
2 participants
@gitfool @patriksvensson