Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log set of issues when node group in degraded state #879

Merged

Conversation

stefanSpectro
Copy link

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR implements code so that when an EKS NodeGroup goes into a Degraded state, we return the Health Issues for the given Node Group as an error. Previously an error was being returned with no context as to what happened on the AWS side. This is the first initial PR relating to the work of getting CAPA to properly reconcile Degraded Node Groups.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://spectrocloud.atlassian.net/browse/PCP-2384
Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@spectro-prow
Copy link

@stefanSpectro: The label(s) kind/bug cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR implements code so that when an EKS NodeGroup goes into a Degraded state, we return the Health Issues for the given Node Group as an error. Previously an error was being returned with no context as to what happened on the AWS side. This is the first initial PR relating to the work of getting CAPA to properly reconcile Degraded Node Groups.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
https://spectrocloud.atlassian.net/browse/PCP-2384
Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@pavansokkenagaraj pavansokkenagaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sadysnaat
Copy link

@stefanSpectro this is really great, could you please help reference upstream PR for the same.

@stefanSpectro stefanSpectro force-pushed the PCP-2384/capture-ng-health-status-with-details branch from ab08b39 to a607701 Compare February 22, 2024 23:15
@stefanSpectro
Copy link
Author

stefanSpectro commented Feb 22, 2024

@sadysnaat I have opened an upstream PR for the same code change: kubernetes-sigs#4811

Do you mind reviewing this PR in our fork? Or am I ok to merge?

@stefanSpectro
Copy link
Author

@sadysnaat Upstream PR has been reopened and is ready for them to review. Can we review this PR for our fork in the meantime?

Upstream responses can be very delayed. This PR isnt functionally changing much it is just returning a more descriptive error. Hoping to get this into our fork without having to wait for upstream.

Let me know.

Thanks

@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pavansokkenagaraj, snehala27, stefanSpectro
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@snehala27 snehala27 merged commit ed75378 into spectro-master Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants