-
Notifications
You must be signed in to change notification settings - Fork 0
Capture upload via web UI #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@LLKruczek let's work on this PR; I closed #160 , but check the unresolved conversations there and ping me when ready. |
413bfb3
to
2041c73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a capture upload feature via the web UI, allowing users to upload files and create captures through a browser interface.
- Adds new views for file upload validation, file content checking, and capture creation
- Implements client-side file deduplication using BLAKE3 hashing to avoid uploading duplicate files
- Provides a modal-based UI with support for folder uploads, capture type selection, and chunked file uploads
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
gateway/sds_gateway/users/views.py | Adds UploadCaptureView and CheckFileExistsView for handling file uploads and duplicate checking |
gateway/sds_gateway/users/urls.py | Registers new upload endpoints for web UI access |
gateway/sds_gateway/templates/users/file_list.html | Implements comprehensive upload modal UI with progress tracking and file validation |
gateway/sds_gateway/static/css/file-list.css | Adds styling for upload modal components |
gateway/sds_gateway/api_methods/views/file_endpoints.py | Removes debug logging statements |
gateway/sds_gateway/api_methods/views/capture_endpoints.py | Refactors capture creation with better error handling and transaction management |
gateway/sds_gateway/api_methods/utils/metadata_schemas.py | Fixes circular import issues in capture type handling |
gateway/sds_gateway/api_methods/serializers/file_serializers.py | Removes debug logging from file existence checking |
gateway/sds_gateway/api_methods/helpers/file_helpers.py | Adds helper functions for file upload and capture creation operations |
gateway/config/settings/base.py | Increases file upload limits for handling larger uploads |
Comments suppressed due to low confidence (1)
gateway/sds_gateway/users/views.py:1
- Missing space in log message: 'conflictsfor' should be 'conflicts for'.
import datetime
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just undo the changes to pyproject.toml
; then run make test
, make pre-commit
and merge it if it looks good - thanks
3dee8a2
to
5e92997
Compare
This reverts commit 0b22063. Reason: failing tests.
@LLKruczek some tests are failing on this branch:
|
664693b
to
d2e6843
Compare
modified: gateway/config/settings/base.py new file: gateway/sds_gateway/api_methods/helpers/file_helpers.py modified: gateway/sds_gateway/api_methods/models.py modified: gateway/sds_gateway/api_methods/serializers/file_serializers.py
d2e6843
to
3bea963
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are failing SDK integration tests. I'll send you the details.
SFDS-30