Some fixes #376
Merged
Some fixes #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputStringOriginally it was a copy of
ImGui::InputTextfrom imgui_stdlib.cpp and used to call the ImGui C function, but on the commit below, it started calling the function it was copied from, without removing the the previous code, making the assert to fail on debug and executing some unnecessary code3b70edc#diff-1da18dbcb5bae1fe88bb2854c55ac61aa27b5afe3204a14fc975ad31460bc1c1R173
LuaConsole::executedump_stringfunction wasn't being called protected, crashing the game if there was an error on itdump_stringtried to get an entity's user data, it couldn't get the backend and crashed (returned an unhandled error)