Online scripts compatibility stuff pt. 2 #382
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script state is now in local_state_datas The deadlock was between a thread with g_all_backends_mutex and another with global_lua_lock
|
So this is all the changes in previous PR + new stuff? |
|
The idea is that the previous PR gets merged first, then the changes of this one will be more clear |
g_SpawnTypeFlags is now SYSTEMIC by default because when some threads run spawns for the first times, the SYSTEMIC flag may not be set, causing desyncs online
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback with LuaBackend's timeouts, callbacks and script state, perhaps I should try using the
custom_allocator, for the first try I decided to just copy stuff manually when the game does too, and seems to work fine, and I'm not sure which one would be better.This is the continuation of #369