Fix damage virtual in the api doc #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this break compatibility with the previos |
No, you can still call it like: entity:damage(damage_dealer_uid, damage_amount, stun_time, velocity_x, velocity_y)
entity:damage(damage_dealer_uid, damage_amount, stun_time, velocity_x, velocity_y, iframes)
entity:damage(damage_dealer, damage_amount, damage_flags, velocity, unknown_damage_phase, stun_amount, iframes, unknown_is_final)unless i missed something? can't test the current overlunky version right now |
|
Ah I see, yeah it should work I think |
Mr-Auto
commented
May 17, 2024
| /// NoDoc | ||
| bool broken_damage(uint32_t damage_dealer_uid, int8_t damage_amount, uint16_t stun_time, float velocity_x, float velocity_y, std::optional<uint8_t> iframes) | ||
| { | ||
| auto dealer = get_entity_ptr(damage_dealer_uid); |
There was a problem hiding this comment.
One think i worry about, this should check if the uid is -1 vs get_entity_ptr returning nullptr
As the first one is probably intended, when the second might be not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.