Add get_liquids_at function and small stuff

[estebanfer]

I added the ENTITY_MASK enum, I didn't if name it MASK because sounds too much of a generic name, but if someone thinks it's fine then I'll change it

[Mr-Auto]

We use 0 as ANY, not NONE. This can be confusing, maybe just add both?

[estebanfer]

Perhaps both, it was weird to do something like (mask & ENTITY_MASK::WATER) == ENTITY_MASK::ANY

[Mr-Auto]

I would do == 0 in that case. Or the inverse != ENTITY_MASK::WATER
Using mask to test for another mask feels weird
(and yes, i know it it's not allowed by default with enum class in C++ to just compare with integer)

[estebanfer]

it's kinda annoying that it's not possible to just do if (mask & ENTITY_MASK::WATER) and you have to do either (mask & ENTITY_MASK::WATER) == ENTITY_MASK::WATER or static_cast<uint32_t>(mask & ENTITY_MASK::WATER)

[estebanfer]

Would this be fine in aliases.hpp?

template <class T>
bool test_flags(T flags, T test_flags)
{
    return (flags & test_flags) == test_flags;
}

[Dregu]

Whatever you think makes this enum easier to use and compare is fine.

[Mr-Auto]

Btw. I'm still trying to figure out why would anyone want to know number of liquid entity/particles in a tile?
what's the use?

[estebanfer]

The array is how the game mostly checks for liquid collisions (eg. Entity:is_in_liquid() uses it), it makes sense to also use it for mods, and not be checking for if every blob of liquid is colliding a hitbox