Skip to content

qml: ExceptionDialog: put user_text inside Flickable #10051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SomberNight wants to merge 1 commit into
base: master
Choose a base branch
from
Open

qml: ExceptionDialog: put user_text inside Flickable #10051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions electrum/gui/qml/components/ExceptionDialog.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,21 @@ ElDialog
Layout.fillWidth: true
text: qsTr('Please briefly describe what led to the error (optional):')
}
TextArea {
id: user_text
Layout.fillWidth: true
Flickable {
Copy link
Copy Markdown
Member

@accumulator accumulator Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is controls/ElTextArea that aims to solve the scrolling issue as well (albeit still a bit glitchy in its current form). It is used in e.g. SignVerifyMessageDialog.qml

width: parent.width
Copy link
Copy Markdown
Member

@accumulator accumulator Jul 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid binding width (or height, x, y) in direct children of Layout. Direct children should as a rule of thumb always use Layout attached properties, e.g. Layout.fillWidth: true, or Layout.preferredWidth: 100, as Layout takes control of these properties in its children.

Layout.fillHeight: true
background: Rectangle {
color: Qt.darker(Material.background, 1.25)
contentHeight: user_text.height
interactive: height < contentHeight
clip: true

TextArea {
id: user_text
width: parent.width
height: Math.max(implicitHeight, 100)
wrapMode: TextInput.WordWrap
background: Rectangle {
color: Qt.darker(Material.background, 1.25)
}
}
}
Label {
Expand Down