Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #38: addresses linting errors introduced by recent code changes. #43

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Issue #38: addresses linting errors introduced by recent code changes. #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions page_queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,8 @@ func (q *QueuePage) moveSongUp() {
}

if currentIndex == 1 {
q.ui.player.Stop()
// An error here won't affect re-arranging the queue.
_ = q.ui.player.Stop()
}

// remove the item from the queue
Expand All @@ -204,7 +205,8 @@ func (q *QueuePage) moveSongDown() {
}

if currentIndex == 0 {
q.ui.player.Stop()
// An error here won't affect re-arranging the queue.
_ = q.ui.player.Stop()
}

if currentIndex > queueLen-2 {
Expand All @@ -223,7 +225,8 @@ func (q *QueuePage) shuffle() {
return
}

q.ui.player.Stop()
// An error here won't affect re-arranging the queue.
_ = q.ui.player.Stop()
q.ui.player.Shuffle()

q.queueList.Select(0, 0)
Expand Down
4 changes: 4 additions & 0 deletions page_search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,10 @@ func (s *SearchPage) addArtistToQueue(entity subsonic.Ider) {

for _, album := range response.Artist.Album {
response, err = s.ui.connection.GetAlbum(album.Id)
if err != nil {
s.logger.PrintError("addArtistToQueue unable to get album artist from server", err)
return
}
sort.Sort(response.Album.Song)
for _, e := range response.Album.Song {
for _, art := range e.Artists {
Expand Down